search

roc230 / spymemcached

Automatically exported from code.google.com/p/spymemcached
0 stars 0 forks source link

when using a binary client, the full fidelity of a Java String should be allowed #213

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Currently, the client tries to validate keys with the validateKey() method to 
ensure it catches protocol violations before cluttering up the network.  

In the case of binary protocol, this actually isn't recommended.  We should 
allow spaces, carriage returns and even multi-byte characters.  It's merely the 
length that should be considered.

Original issue reported on code.google.com by ingen...@gmail.com on 24 Oct 2011 at 11:44

GoogleCodeExporter commented 9 years ago 
Assigning to Dustin, as I seem to remember there was some reason to not do 
this.  If I'm incorrect, please assign it back.  Should this be implemented?

Original comment by ingen...@gmail.com on 24 Oct 2011 at 11:45

GoogleCodeExporter commented 9 years ago 
I remember the decision to keep the keys accessible from both protocols.  I 
don't *actually* care if we want to support it, but nobody's written a test 
that would suggest it wouldn't break stuff.

Original comment by dsalli...@gmail.com on 25 Oct 2011 at 2:44

GoogleCodeExporter commented 9 years ago

Original comment by ingen...@gmail.com on 25 Oct 2011 at 9:02

GoogleCodeExporter commented 9 years ago 
Changing the status back to new here since there doesn't seem to be a decision 
on whether or not we want to fix this.

Original comment by mikewie...@gmail.com on 30 Nov 2011 at 4:26

GoogleCodeExporter commented 9 years ago

Original comment by ingen...@gmail.com on 19 Aug 2012 at 8:10

GoogleCodeExporter commented 9 years ago 
This is available since on of the higher 2.8 releases! Just grab 2.9 and you 
should be good. We make use of this inside the couchbase SDK too.

Original comment by michael....@gmail.com on 6 Jun 2013 at 1:07