search

rocicorp / repc

The canonical Replicache client, implemented in Rust.
Other
30 stars 7 forks source link

Customer report that concurrent mutations don't work #181

Closed aboodman closed 4 years ago

aboodman commented 4 years ago

@arv saw that concurrent mutations in the unit tests deadlock, unclear if same issue.

phritz commented 4 years ago

pointer from our side: https://github.com/rocicorp/replicache-sdk-js/blob/cc617fbf853b46c39268e50cb59229f76a1f13ca/src/replicache.test.ts#L453 is skipped

phritz commented 4 years ago

https://github.com/rocicorp/replicache-sdk-js/blob/cc617fbf853b46c39268e50cb59229f76a1f13ca/src/replicache.test.ts#L453

This test is testing behavior we no longer have so this is WAI unless we want to change how locking works. https://rocicorp.slack.com/archives/C014J5KGBHP/p1600450430008800?thread_ts=1600299620.012000&cid=C014J5KGBHP

phritz commented 4 years ago

@aboodman when you fix the test can you close this? I don't think there is anything actionable here other than fixing the test.