search

rocjs / roc-template-web-app-react

A basic template for a React application
MIT License
6 stars 4 forks source link

Enhancement/nextgen #15

Closed andreasrs closed 7 years ago

andreasrs commented 7 years ago

Features:

Some screens: 2016-12-04-183118_672x300_scrot

The template will add/remove menu items as selected during project init.

2016-12-04-184042_828x657_scrot

2016-12-04-184101_812x798_scrot

2016-12-04-184115_826x651_scrot

andreasrs commented 7 years ago

For testing this PR branch locally in a directory called roctest, one could use wget https://github.com/rocjs/roc-template-web-app-react/archive/enhancement/nextgen.zip && roc new roctest ./nextgen.zip

I could not get the branch-specifier to work, and not had the time to look into it yet.

andreasrs commented 7 years ago

Thanks for the comments @dlmr - do you have any feedback on the conceptual level? Do you think the redux and fetch is a good initial optional split?

I'll go over an clean up the code once that has been decided. Also, did you have an alternative colour-set suggestion?

I also think we should consider a (separate) super-minimalistic template with as few opinions as possible. For those that just want to get started with an empty component.

dlmr commented 7 years ago

It is possible to install this directly without the need of using wget but it is a little tricky because of a bug in the template logic. I have created a PR that addresses this https://github.com/rocjs/roc/pull/153.

To install directly use the clone path along with the branch name, like this:

$ roc init git@github.com:rocjs/roc-template-web-app-react.git enhancement/nextgen

Regarding the conceptual level. I think this is a great start but I would like to see that the "default" version, when answering no to everything or a higher level question, results in an almost empty project with only a single App.js or similar. This is my take on what you are describing as "super-minimalistic template ".

One thing that might be confusing for beginners is that there is data fetching in both the data-fetching example and the Redux example. One might think that you will not get any data fetching if only selecting Redux. One way of addressing this is to tell the user that data fetching will be included if selecting the Redux example.

andreasrs commented 7 years ago

I think we can squash+merge this now @dlmr Then we can update our tutorial on current getroc.org to not use the wip branch.

If we want to make the "simple" case even cleaner and more simple, I propose we do it separately in another PR.

andreasrs commented 7 years ago

@dlmr ping 🎉

dlmr commented 7 years ago

🎉