search

rock-core / autoproj

Rock (Robot Construction Kit) package-oriented build system
http://rock-robotics.org/rock-and-syskit/workspace
23 stars 22 forks source link

Improve load_config_once_with_permission documentation #376

Open planthaber opened 2 years ago

doudou commented 2 years ago

hi @planthaber. CI does not pass because Rubocop changed a config name. Would you mind renaming the entry to make it pass ? That would be very helpful.

planthaber commented 2 years ago

I tried to fix the rubocop conifg, but wehn i follow the hint:

The Gemspec/DateAssignment cop has been removed. Please use Gemspec/DeprecatedAttributeAssignment instead.

I'm getting the next error:

Error: unrecognized cop or department Gemspec/DeprecatedAttributeAssignment found in .rubocop.yml Did you mean Gemspec/OrderedDependencies?

For me it looks like there is no valid replacement, I removed it

Then, it complains about:

lib/autoproj/os_package_installer.rb:188:34: W: [Correctable] Lint/RedundantCopDisableDirective: Unnecessary disabling of Lint/EmptyWhen.

When I remove it:

lib/autoproj/os_package_installer.rb:188:17: W: Lint/EmptyWhen: Avoid when branches without a body.

So it is not just renaming ;-)

planthaber commented 2 years ago

Now it seems to work:

Deleted the "Gemspec/DateAssignment" cop

and

Fixed "lib/autoproj/os_package_installer.rb:188" issue by calling "nil" (noop), based on https://stackoverflow.com/questions/13452624/equivalent-of-pass-in-ruby