search

rock-core / base-doc

Rock's website
0 stars 11 forks source link

Syntax fixes #13

Closed doudou closed 9 years ago

doudou commented 10 years ago

This is a cherry-pick of the work by @charrius and supersedes #6, #7 and #8

marvin2k commented 10 years ago

hm. created an additional pull-request for this branch from an updated version of this branch in my fork... well... anyhow: changes here look fine to merge

marvin2k commented 10 years ago

ah, just because I previously stumbled over this while reading the diffs: its really and intentionally meant to be syskit instanciate??? It is a misspelling of instantiate. And its all over the place. But I assume nobody is ever going to fix this wart?

doudou commented 9 years ago

ah, just because I previously stumbled over this while reading the diffs: its really and intentionally meant to be syskit instanciate??? It is a misspelling of instantiate. And its all over the place. But I assume nobody is ever going to fix this wart?

Let's say that everyone got used to it ... Bloody french. Using a c in instantiate. What a bunch of douchebags :P

doudou commented 9 years ago

And merged

marvin2k commented 9 years ago

;-)

Meta-Opinion: Stuff like this should be fixed in an honest framework...

doudou commented 9 years ago

Meta-Opinion: Stuff like this should be fixed in an honest framework...

Agreed. The problem is that the priority of something like that is IMO very low (especially since it is both (1) pretty harmless and (2) really painful to fix since the code itself uses instanciate too)

I would not reject pull requests which fix the spelling in a backward-compatible way, though.