search

rock-slam / slam-orogen-orientation_estimator

Rock module/task in order to estimate the orientation or attitude of a rigid body.
2 stars 2 forks source link

move frame configuration at the task's toplevel #5

Closed doudou closed 8 years ago

doudou commented 8 years ago

Unless I am mistaken, the body frame and output's source frame are required to be the same. Moreover, the convention for frame configuration (as done in the transformer) is to have a property called _frame, e.g. here world_frame. This convention is required by e.g. Syskit for the transformer configuration

doudou commented 8 years ago

Anybody here ?

jhidalgocarrio commented 8 years ago

It makes sense for me +1 Nevertheless, I would like @saarnold to review this PR. I am not very familiar with this part of the code for this component and not fan of the "source to target" configurations.

saarnold commented 8 years ago

:+1: Sorry for the delay, I must have missed this PR last time.

doudou commented 8 years ago

Sorry for the delay, I must have missed this PR last time.

No worries. I do believe it is the OP's job to give reminders about pending pull requests.