search

rockdaboot / mget

Multithreaded metalink/file/website downloader (like Wget) and C library
GNU Lesser General Public License v3.0
113 stars 19 forks source link

Failing Tests #19

Closed darnir closed 10 years ago

darnir commented 10 years ago

I tried to compile and test libmget. The following 3 tests fail on my Debian Stable system:

Test-iri Test-iri-percent Test-restrict-ascii

I haven't had the time to look into what exactly is going wrong.

rockdaboot commented 10 years ago

Hi Darshit, nice to see you here.

Could you give me the summary of your ./configure run ? (last lines of ./configure output) I guess there might be some packages not installed.

darnir commented 10 years ago

Nice to be here.

Here's my configure summary:

configure: Summary of build options:

  Version:           0.1.5
  Host OS:           linux-gnu
  Install prefix:    /usr/local
  Compiler:          gcc
  CFlags:            -g -std=gnu99 -pedantic -fPIC -Wall -Wstrict-prototypes -Wold-style-definition -Wmissing-prototypes -Wwrite-strings -Wformat=2 -Wformat -Wformat-security -Wsign-compare -Wextra -D_FORTIFY_SOURCE=2 -Wcast-align -O2 
  LDFlags:           -fPIE -pie -Wl,--as-needed -ffunction-sections
  Libs:              -lgnutls -lz  -lbz2 -lidn  -lrt -lpthread 
  SSL support:       yes
  GZIP compression:  yes
  BZIP2 compression: yes
  LZMA compression:  no
  IDN support:       -lidn
  Tests:             Valgrind testing not enabled

Also, I'm not sure if all those CFLAGS should be there by default. Should allow the user/packager to set most of these manually.

rockdaboot commented 10 years ago

Try: apt-get install libidn2-0 libidn2-0-dev libunistring0 libunistring-dev It resolves all test failures here...

CFlags: I agree. What is the standard ? -O2 -Wall ? Maybe I need those -fPIC -fPIE flags... don't remember right now.

Checkout branch 'develop' to have the latest code or want to hack. 'master' is for releases only.

rockdaboot commented 10 years ago

These default flags are only set when you didn't specify CFLAGS and your compiler is gcc. I want these to prevent contributors introducing warnings that I have to care about later. I have my own CFLAGS set in .bashrc with some additional stuff.