Closed sneakertack closed 9 years ago
@sneakertack: Great work! I'm impressed that you added documentation & tests and that all of it (implementation, docs & tests) is in keeping with the styles and conventions of the project. Thank you!!
@sneakertack: FYI, this has been pushed to npm as 1.2.0
Addresses #64 and #66.
@prust I've gone with your recommendation of still leaving the join criteria mandatory, except on cross join.
Here are the nuances of this commit:
.crossJoin('some_table')
without any onCriteria is now the expected use case..crossJoin('t2').on({'foo':'bar'})
) will not fail; it will just silently discard ON/USING. You may or may not wish to change this.Note that this branch is based off the
join-using
branch.