search

rocker-org / devcontainer-features

A collection of Dev Container Features.
https://rocker-project.org/images/devcontainer/features.html
MIT License
52 stars 16 forks source link

[miniforge] install should not fail if conda/mamba are already present #166

Closed rokroskar closed 1 year ago

rokroskar commented 1 year ago

The install fails here if conda/mamba are already installed: https://github.com/rocker-org/devcontainer-features/blob/54829966edca06bd81e58a38ad28b57a993fd6e5/src/miniforge/install.sh#L15

The exit code should be 0 so as to not break a devcontainer build in case a base image is used which already contains conda/mamba.

eitsupi commented 1 year ago

Thanks for pointing that! Could you make a PR to fix this?

rokroskar commented 1 year ago

I wasn't sure if this was done intentionally, but it sounds like it was not in which case I'm happy to send a PR.

eitsupi commented 1 year ago

I wasn't sure if this was done intentionally, but it sounds like it was not in which case I'm happy to send a PR.

Yes, I think the changes you suggest make sense, and I would be willing to review and merge that if you send a PR.