search

rockymeza / wifi

[unmaintained] WiFi tools for linux
http://pypi.python.org/pypi/wifi
BSD 2-Clause "Simplified" License
305 stars 151 forks source link

Sudo args #74

Open Erf- opened 9 years ago

Erf- commented 9 years ago

Hi Rockymeza. I added some 'sudo' args and the tests related to your connection and scannig methods. Then, I also impleted some tests on their calls. I implemented some dummydata to group all test variables and I modified their calls in test codes.

rockymeza commented 9 years ago

Hi @Erf-,

First of all thank you for this work, I appreciate it. I think that adding a sudo argument is important (see #66), but at the same time, there are too many changes in this pull request some of which I agree with and some of which I don't agree with.

It would be great if we could separate this pull request into two:

  1. add sudo argument
  2. refactor the tests

And we could disect/discuss them separately.

What do you think?

Erf- commented 9 years ago

Ok I saw your comments and I am trying to match with them.