roclark / sportsipy

A free sports API written for python
MIT License
496 stars 191 forks source link

Team Rebounds & Turnovers not Included in CBB Data #279

Closed john3842 closed 5 years ago

john3842 commented 5 years ago

Describe the bug Team Rebounds aren't included in College Basketball Boxscores, so Offensive and Defensive Rebounds are off. For example, if the ball is deflected out of bounds on a rebound, the team that gets the ball OOB gets a team rebound. Same goes for Team Turnovers, potentially Team Technical Fouls (Tech on the coach).

To Reproduce See Box Score for Green Bay vs. Wisconsin on November 21st, 2019. Green Bay should have 25 rebounds, Wisconsin 39.

roclark commented 5 years ago

Hey @john3842, thanks for writing this up! I see what you mean about the data missing the team turnovers and rebounds. After looking at the website, however, I am struggling to find anything that indicates team turnovers/rebounds on the boxscore page. For example, I looked at the game you mentioned, but I only see offensive/defensive rebounds, and total rebounds being the sum of those two. I'm probably looking in the wrong places, but would you mind sharing any details on where I can pull this information from so I can include it?

Thanks again!

john3842 commented 5 years ago

Hey Robert,

I see what you mean on Sports Reference itself. It looks like there's no "Team Stats" table to easily pull the information from. I was just comparing with ESPNhttps://www.espn.com/mens-college-basketball/matchup?gameId=401166085 and CBShttps://www.cbssports.com/college-basketball/gametracker/live/NCAAB_20191121_WISGB@WISC/' box score for that Wisconsin vs. Green Bay game and noticed the discrepancy.

Unfortunately, I'm not sure if there's an easy way to pull this information. It may not be something worth fixing, as it's not all that common, but I wanted to point it out to you nonetheless just in case. I very much appreciate your work on this API!

Best


From: Robert Clark notifications@github.com Sent: Monday, November 25, 2019 3:56 PM To: roclark/sportsreference sportsreference@noreply.github.com Cc: Johnson, Ryan john3842@msu.edu; Mention mention@noreply.github.com Subject: Re: [roclark/sportsreference] Team Rebounds & Turnovers not Included in CBB Data (#279)

Hey @john3842https://urldefense.com/v3/__https://github.com/john3842__;!ioFpBMP7lJU!m80cA7eEbge8oFvHUGLNUexgv7ZzCgaviUjShP19P-p4fVpzA9EB-m4pUQgE8znCcoI$, thanks for writing this up! I see what you mean about the data missing the team turnovers and rebounds. After looking at the website, however, I am struggling to find anything that indicates team turnovers/rebounds on the boxscore page. For example, I looked at the game you mentionedhttps://urldefense.com/v3/__https://www.sports-reference.com/cbb/boxscores/2019-11-21-21-wisconsin.html__;!ioFpBMP7lJU!m80cA7eEbge8oFvHUGLNUexgv7ZzCgaviUjShP19P-p4fVpzA9EB-m4pUQgE0Eg6nAE$, but I only see offensive/defensive rebounds, and total rebounds being the sum of those two. I'm probably looking in the wrong places, but would you mind sharing any details on where I can pull this information from so I can include it?

Thanks again!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https://github.com/roclark/sportsreference/issues/279?email_source=notifications&email_token=AEFZB6DXS4LHQ23VIX456QLQVQ3W7A5CNFSM4JRKOI6KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFDYSJQ*issuecomment-558336294__;Iw!ioFpBMP7lJU!m80cA7eEbge8oFvHUGLNUexgv7ZzCgaviUjShP19P-p4fVpzA9EB-m4pUQgEmpSfFLw$, or unsubscribehttps://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/AEFZB6AOZFCT74F4NYI5ZILQVQ3W7ANCNFSM4JRKOI6A__;!ioFpBMP7lJU!m80cA7eEbge8oFvHUGLNUexgv7ZzCgaviUjShP19P-p4fVpzA9EB-m4pUQgEp0zgPWc$.

roclark commented 5 years ago

Thanks for the update @john3842! Yeah, looks like the website is missing that information unfortunately. I think they update their site fairly frequently, so perhaps they will add those stats in the future, but it looks like there isn't a whole lot I can do about this now. Thanks again for bringing this up! I will re-open this if I find that the website gets updated with the info.