search

rodionmoiseev / c10n

A Java library, focused on making internationalisation more modular, easier to evolve and maintain, robust-to-change and IDE-friendly without excess of external tools.
Apache License 2.0
67 stars 10 forks source link

Use openjdk to build on travis #45

Closed kevinrobayna closed 4 years ago

kevinrobayna commented 4 years ago

Oracle dependency is not available anymore (widely not only travis) Updating to use the openjdk one.

https://travis-ci.community/t/install-of-oracle-jdk-8-failing/3038

kevinrobayna commented 4 years ago

@rodionmoiseev take a look to the pr, it think it should work. I also added an action from GitHub so that the test are run on the PR. #44

I think we should upgrade the project to a higher version of java.

rodionmoiseev commented 4 years ago

@kevinrobayna awesome, thanks! I will take a look at it tonight 👍

rodionmoiseev commented 4 years ago

@kevinrobayna thanks for the fix. Works beautifully!

Sorry, I decided to skip your commit for the github workflow, as I failed to see the value it brings. I don't understand much about github actions, but it seems to be using some other build system different to Travis, and I don't want to mix the two. Travis seems to be doing a decent job at building PRs already (see here: https://travis-ci.org/rodionmoiseev/c10n/pull_requests).

If we switch the CI system to the Github one, then removing Travis at the same time would be better. But again, I am pretty content with Travis for the moment. Cheers.

rodionmoiseev commented 4 years ago

I think we should upgrade the project to a higher version of java.

Opened a new issue #46 and a new milestone 2.0

kevinrobayna commented 4 years ago

ah sorry! I did not see the PRs being build on the PR itself but I forgot to look at travis 😅

Yes you're right it's best to have only one platform to build things and travis does work beautifully

rodionmoiseev commented 4 years ago

Travis PR integration is a little weak in github. Afaik it only appears as a small check on the PR list. Also for some reason the check does not appear on most PRs... :(

image

kevinrobayna commented 4 years ago

the pr it appears is an old one, I guess there's some kind of permission that might have expired? since travis need your permission to add things to your PRs