Take hidegroupmembers from activity setting.

rogerbaba / moodle-mod_groupselect

Group self formation module for Moodle

https://moodle.org/plugins/mod_groupselect

6 stars 12 forks source link

Take hidegroupmembers from activity setting. #75

Closed lucaboesch closed 4 years ago

lucaboesch commented 4 years ago

Hi Roger

Unfortunately you missed an occurence of $hidegroupmembers = $groupselect->hidegroupmembers; which lead to a bug, by which group members weren't able to see each other any more.

I created this patch for you and also added Behat tests to check the behaviour and display. Additionally there are some slight changes to the .travis.yml file so it passes the new requirements checked by the validation tool Travis CI Build Config Explorer.

Best, Luca

rogerbaba commented 4 years ago

Good catch i fix asap, but needs also tho show the group members always if the participants has the capabilities in moodle.