search

rogerbaba / moodle-mod_groupselect

Group self formation module for Moodle
https://moodle.org/plugins/mod_groupselect
6 stars 12 forks source link

Adding activity dates information fixes #89. #90

Closed lucaboesch closed 2 years ago

lucaboesch commented 2 years ago

Hi Roger

I built in the activity dates. Besides, you probably want to undo the handling of Moodle < 4.0 versions in https://github.com/rogerbaba/moodle-mod_groupselect/commit/6f5bc2d50bfdb3ebe2a2a0755a68b6678039247b because of what’s explained here https://github.com/ndunand/moodle-mod_choicegroup/issues/172. It creates an incompability with 3.11 and earlier. I fixed this with that pull request, too, using this trick here https://github.com/ndunand/moodle-mod_choicegroup/blob/master/lib.php#L54. As you see, the Github actions do pass with Moodle 3.11, 4.0 and master.

Best, Luca

lucaboesch commented 2 years ago

I'll create a new pull request for better comparability and GitHub Actions.