search

roidrage / lograge

An attempt to tame Rails' default policy to log everything.
http://www.paperplanes.de/2012/3/14/on-notifications-logsubscribers-and-bringing-sanity-to-rails-logging.html
MIT License
3.47k stars 300 forks source link

Fix broken CI #370

Closed y-yagi closed 1 year ago

y-yagi commented 1 year ago

This PR tries to fix the broken CI.

First, disable Gemspec/DependencyVersion cop

Currently, CI is broken because of Gemspec/DevelopmentDependencies cop. https://github.com/roidrage/lograge/actions/runs/5100966316/jobs/9169550600#step:4:36

Rubocop recommends to write development dependencies in Gemfile. But this gem has multiple Gemfiles and it might be redundant. So I disable it to pass Rubocop.

Second, bump truffleruby to the latest. Because truffleruby-21.3 for Ubuntu 22.04 doesn't exist. https://github.com/ruby/ruby-builder/releases/tag/toolcache

Third, support edge Rails. Since, https://github.com/rails/rails/pull/45796, ActiveSupport::Notifications.notifier.listeners_for doesn't return all listeners. Need to use all_listeners_for to get all listeners.

y-yagi commented 1 year ago

Sorry after the approval, but I added commits that support edge Rails. I think those allow to all test passed. I confirmed that with my fork https://github.com/y-yagi/lograge/pull/2