search

rojo-rbx / vscode-rojo

Visual Studio Code plugin for Rojo
https://marketplace.visualstudio.com/items?itemName=evaera.vscode-rojo
Mozilla Public License 2.0
35 stars 23 forks source link

Suggestion: Make it possible to hide the "Use aftman instead of foreman" popup #73

Open AmberGraceRblx opened 2 years ago

AmberGraceRblx commented 2 years ago

Currently, a message shows up everytime you start syncing with Rojo. Conflicts of interest notwithstanding, I don't want this advertisement showing up every time I start syncing with Rojo, nor do I want to have to uninstall rojo via foreman in order to use this extension.

evaera commented 2 years ago

We can look at making the notice only appear one time on first load. I think the notice is still valuable because Foreman has a bug that makes the extension not work correctly (it doesn't terminate sub-processes correctly), and the main reason we put that notice there was to warn users about that bad behavior caused by Foreman

AmberGraceRblx commented 2 years ago

the main reason we put that notice there was to warn users about that bad behavior caused by Foreman

Right... Have you made any efforts at getting this fixed in the Foreman library itself (e.g. writing a pull request to fix this issue)? Foreman is a much more widely used library, not Aftman, because it's been the library officially supported by Roblox for the past two years. Suggesting to use an entirely new library seems like an odd solution here, with big conflict of interest.

LPGhatguy commented 2 years ago

Hello! I'm the creator of both Foreman and Aftman. I donated Foreman to Roblox while I was employed there, and Roblox kept ownership over it due to their widespread internal use.

Aftman is a better fit for extensions that want to depend on native binaries. Some other extensions are considering adopting it as their backend for fetching binaries as well. We can fix this message, I agree that it is too aggressive.

Foreman has had an issue about process termination issues for a few months. While there isn't currently a PR opened against Foreman, a diff has been posted that's almost strictly additive.

More than just that issue, Aftman fixes a few fundamental issues with Foreman. In particular, Aftman's trust model and exact version dependencies are important for the foundation of an extension like this one to protect users from accidentally running untrusted code.

Right... Have you made any efforts at getting this fixed in the Foreman library itself (e.g. writing a pull request to fix this issue)? Foreman is a much more widely used library, not Aftman, because it's been the library officially supported by Roblox for the past two years. Suggesting to use an entirely new library seems like an odd solution here, with big conflict of interest.

This response is inappropriate and was not warranted. When a decision is made that doesn't seem to make sense, often there is information that you hadn't considered. Being rude to maintainers is never the right call: you are getting something for free created by volunteers.