rojo-rbx / vscode-rojo

Visual Studio Code plugin for Rojo
https://marketplace.visualstudio.com/items?itemName=evaera.vscode-rojo
Mozilla Public License 2.0
35 stars 23 forks source link

Make aftman skip trust check when installing #87

Closed RyanLua closed 6 months ago

RyanLua commented 6 months ago

Fixes when you have untrusted tools and try to use the extension, it errors.

image

Some notes are that we should be using the --skip-untrusted flag but it isn't implemented yet. When it does release we should be skipping untrusted tools instead of installing them.

evaera commented 6 months ago

This is a huge security risk. There is already a solution to this problem presented in the error message: the user can decide to trust the tool themselves.

On Thu, Feb 22, 2024 at 1:45 PM, Ryan Luu @.***(mailto:On Thu, Feb 22, 2024 at 1:45 PM, Ryan Luu < wrote:

Fixes when you have untrusted tools and try to use the extension, it errors.

image.png (view on web)

Some notes are that we should be using the --skip-untrusted flag but it isn't implemented yet. When it does release we should be skipping untrusted tools instead of installing them.


You can view, comment on, or merge this pull request online at:

https://github.com/rojo-rbx/vscode-rojo/pull/87

Commit Summary

  • 56c84a6 Make aftman skip trust check

File Changes

(1 file)

Patch Links:

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you are subscribed to this thread.Message ID: @.***>