search

rojo-rbx / vscode-rojo

Visual Studio Code plugin for Rojo
https://marketplace.visualstudio.com/items?itemName=evaera.vscode-rojo
Mozilla Public License 2.0
35 stars 23 forks source link

Make Aftman skip untrusted tools #88

Open RyanLua opened 3 months ago

RyanLua commented 3 months ago

When Aftman is installing tools, use --skip-untrusted so that if there is an untrusted tool, we skip it instead of erroring.

Background

Aftman just released v0.2.8 which adds a new flag, --skip-untrusted that installs only trusted tools.

If --skip-untrusted is given, only already trusted tools will be installed, others will be skipped and not emit any errors.

https://github.com/LPGhatguy/aftman#aftman-install

Currently, if you have an untrusted tool then the Rojo extension would just error. Instead, we should just skip the untrusted tools and let the user deal with it later. image

Notes

If the user has a version of Aftman lower than v0.2.8 then the install will error because the flag --skip-untrusted hasn't been added and therefore doesn't exist.