Investigate possibility of suppressing HTML tags in output

rojopolis / spellcheck-github-actions

Spell check action

MIT License

138 stars 38 forks source link

Investigate possibility of suppressing HTML tags in output #14

Open jonasbn opened 4 years ago

jonasbn commented 4 years ago

Hi @edumco

Thanks for the elaborate feedback. I have compiled your comments to this list:

[ ] Investigate possibility to suppress HTML output from PySpelling

Originally posted by @jonasbn in https://github.com/rojopolis/spellcheck-github-actions/pull/12#issuecomment-636716234

facelessuser commented 4 years ago

There is not currently a way to silence a specific filter's context (which is what the HTML tag info is). Currently, each filter just appends context for each block it returns. It is possible that a feature request could be made over on PySpelling to allow for this to be controlled on each filter if desired. If you are working directly off an HTML file, it can be useful, but I agree it is less useful when we are talking about a Markdown file that is transformed in the pipe and then handed over to the HTML filter.

jonasbn commented 4 years ago

Hi @facelessuser

I am leaning towards dismissing this issue under wont fix, but would you agree that reporting the issue with PySpelling would be a good idea?

facelessuser commented 4 years ago

If you would like me to follow up with it, that'd be the place. If you don't really care, then probably not :slightly_smiling_face: .

edumco commented 3 years ago

By the comments I believe this issue should be closed. Right?

jonasbn commented 3 years ago

I actually do HTML suppression, when running locally, I will see if I can move this into the action in a non-intrusive implementation, so let's keep this open a bit