search

rokwire / illinois-app

Source code repository of "Illinois" App - the official mobile app of the University of Illinois.
https://app.illinois.edu/
Apache License 2.0
23 stars 20 forks source link

[FEATURE] Add Share and Clear "Filtered View" on Event Feed Panel #4041

Closed vburgett closed 3 months ago

vburgett commented 4 months ago

Please add the ability to share and clear a filtered event view in the event feed panel. Please see the PDF:

ShareEventFilteredView.pdf

mihail-varbanov commented 4 months ago

@vburgett, don't you think that lining up the share and clear buttons next to each other on the right side would give a more consistent user experience? I consider that this could increase the chance to mistake the button that the user attempts to tap, but on the other hand it is a common practice to group action buttons on the right (like profile / notification / settings in the header bar above) and keep the left side button for some more general actions like back, drawer menu, etc. This is just a suggestion.

ShareEventFilteredView
mihail-varbanov commented 4 months ago

Implemented in version 5.2.9. There are slight differences to ShareEventFilteredView.pdf design that I hope are for better.

vburgett commented 4 months ago

Thanks, Misho. Did you end up implementing what you shared via your screenshot or another solution?

mihail-varbanov commented 4 months ago

Hi @vburgett. Yes, I did. It is available in 5.2.9 build. Please ask @pmarkhennessy, to provide you with a link to this build.

vburgett commented 4 months ago

It works great. Thank you, @mihail-varbanov.

As part of the styles.json icon clean up, the app uses the solid share icon (see screenshots). Please change this event feed share icon to the same one.

To avoid big thumbs from tapping the clear button instead of the share icon, please align the share icon with the "plus icon" (see screenshot).

Screenshot_20240520-121523 Screenshot_20240520-121542 Screenshot_20240520-121643

mihail-varbanov commented 4 months ago

@vburgett, I think the last request is fulfilled. This is available in version 6.0.1.

vburgett commented 3 months ago

Thank you, @mihail-varbanov. The icons are now aligned but the share icon is still incorrect in 6.0.4 on dev.

mihail-varbanov commented 3 months ago

@vburgett, I think I misunderstood you before. I think share icon is a you want it in 6.0.7.

vburgett commented 3 months ago

The icon you used in 6.0.7 is correct. Thank you, @mihail-varbanov!

Priyaravi8 commented 2 months ago

@mihail-varbanov - I don't see the Clear "Filtered View" icon in version 6.0.17 . Please confirm

image

vburgett commented 2 months ago

@Priyaravi8 you need to have a filtered view before you can clear it. Please add a filter then you will see an X to clear that filter.

Priyaravi8 commented 2 months ago

@vburgett - Thank you. All good.