rokwire / illinois-app

Source code repository of "Illinois" App - the official mobile app of the University of Illinois.
https://app.illinois.edu/
Apache License 2.0
23 stars 20 forks source link

[USABILITY] Event Sub-Category Typo #4046

Closed vburgett closed 4 months ago

vburgett commented 4 months ago

Under Event Filters > Event Category > Recreation, Health and Fitness, please change "Adventure Req" to "Adventure Recreation"

v5.1.34

dobromirdobrev commented 4 months ago

Hi @vburgett ,

We can easily change that label but it will reflect much more than it looks like.

  1. First, these categories and sub-categories are stored on the server side, e.g. Content BB as "attributes" content items. This means that we have to change them on dev, test and respectively prod environments in order to be consistent.
  2. Changing this sub-category label on prod will reflect the released Illinois app 5.1.34. So that the sub-category will start to appear as "Adventure Recreation".
  3. Filtering of the events is made based on that selection. This means that once we change the sub-category from "Adventure Req" to "Adventure Recreation", the events created with sub-category "Adventure Req" will not appear when we try to filter them. This will be valid for the released Illinois app as well.
  4. There is also a mapping for the imported events from Webtools / Campus Rec which will be affected as well.

What I'm trying to say is that this change may cause much more noice than we can expect.

@vburgett , @pmarkhennessy , please take a stand on this and let us know explicitly that you want this renaming. Thanks.

Copying @mihail-varbanov and @petyos so that they can be aware of this.

mihail-varbanov commented 4 months ago

@vburgett, @pmarkhennessy, I am afraid that yesterday I misled @dobromirdobrev that fulfilling this requirement would affect existing events/groups attributes. When I dived into attributes support in the Illinois client app I found out that a long time ago I designed a way to solve a problem like this one exactly. So I updated the attribute definitions on dev/prod/test, both for events and groups, and now the attribute value reads "Adventure Recreation", as requested. Please note that this also affects the existing 5.1 release. Let me know please if you see some issue with this update.

vburgett commented 4 months ago

Confirming as fixed on dev. Thank you!