search

rokwire / illinois-app

Source code repository of "Illinois" App - the official mobile app of the University of Illinois.
https://app.illinois.edu/
Apache License 2.0
23 stars 20 forks source link

[BUG] "Add Cover Image" button is displays on top of cover image #4150

Closed Priyaravi8 closed 3 months ago

Priyaravi8 commented 3 months ago

Describe the bug Added a cover image display along with the button "Add Cover Image" in Create a Group screen

To Reproduce Steps to reproduce the behavior:

  1. Install the app
  2. Navigate to Group
  3. Tap on "+" icon to create a group and Add a cover image

Actual Result Added cover image is displayed on the screen. But the button "Add Cover Image" is visible on top of the added image.

Expected behavior The button "Add Cover Image" should not display once the image is added in the group

Screenshots Cover image

Smartphone (please complete the following information):

TodorBachvarov commented 3 months ago

Hi @Priyaravi8, If we remove this button the user wont be able to change his image if he already made a selection (Example: User tap Add Image -> Select Image -> Comes back to GroupCreatePanel -> but he don't like the image -> he will have to close the panel and start over in order to change the image). I can suggest to change the button text from "Add Cover Image" to "Edit Cover Image" when the user makes selection (same as is PostCreatePanel when user creates group post/message). cc @pmarkhennessy, @vburgett

TodorBachvarov commented 3 months ago

I've implemented my proposal in version 6.0.15. Please let me know if it's good enough.

Priyaravi8 commented 3 months ago

This is fixed.