a.navbar-brand width: 100% problem

rollincode / rails_admin_theme

rails_admin theme flat theme

MIT License

149 stars 120 forks source link

a.navbar-brand width: 100% problem #5

Closed etagwerker closed 8 years ago

etagwerker commented 8 years ago

Hello,

I found this issue when using the theme:

navbar-issue

It goes away if you remove width: 100% from a.navbar-brand

I'm not sure if that's the best solution. I could send a PR if you are interested.

Thanks!

nicovak commented 8 years ago

Thank you for reporting that issue, which web browser are you using ? I can't reproduce the issue.

magnocosta commented 8 years ago

Hello,

I am detected this issue too. I am using Chrome Versão 50.0.2661.102 (64-bit)

Att,

etagwerker commented 8 years ago

@nicovak I was using Chrome version 50.0.2661.102 (64-bit) on Mac OS X 10.11.5

matthv commented 8 years ago

Finally, I have reproduced this issue. @nicovak it's a string length bug. @etagwerker thank you, but your pull request does not fix the bug completely if the "app_name" is too large. I suggest to add white-space: nowrap; Someone can test with a big string ?

etagwerker commented 8 years ago

@matthv Weird, I just tested with a big string and it seems to work fine. What browser did you use to test my solution?

screen shot 2016-06-10 at 4 30 29 pm

matthv commented 8 years ago

I was using chrome version 51.0.2704.84 (64-bit) on Mac OS X 10.11.5. It seems work fine with big word

But same test with multiple spaces

Finally with white-space: nowrap;

nicovak commented 8 years ago

Two commits have been pushed:

Clean code (multiple css declaration of navbar-brand) https://github.com/rollincode/rails_admin_theme/commit/2124e988b21652b657b006c1182ca284055ec072

width 100% removed https://github.com/rollincode/rails_admin_theme/commit/d4433adc7f725ce5605525751068ffcb6d54e368

It's on master branch but I'll create a new version on rubygem.org