search

rolling-scopes / site

🦥🛼 Website supporting The Rolling Scopes and The Rolling Scopes School educational process
https://rs.school
13 stars 10 forks source link

637-feat: Exclude file extansions rule #645

Closed Quiddlee closed 2 weeks ago

Quiddlee commented 2 weeks ago

What type of PR is this? (select all that apply)

Description

Related Tickets & Documents

Screenshots, Recordings

Added/updated tests?

[optional] Are there any post deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

gif

Summary by CodeRabbit

Release Notes

coderabbitai[bot] commented 2 weeks ago

[!CAUTION]

Review failed

The pull request is closed.

📝 Walkthrough ## Walkthrough This pull request primarily modifies import statements across various files in the codebase by removing file extensions such as `.ts` and `.tsx`. Additionally, it introduces updates to the ESLint configuration to enforce the use of file extensions in imports, promoting consistency in the codebase. The changes enhance readability and maintain the existing functionality of the components and tests. ## Changes | File Path | Change Summary | |------------------------------------------------|----------------------------------------------------------------------------------------------------------| | dev-data/communication.data.ts | Import statement updated: removed `.ts` from import path for `DISCORD_LINKS`. | | dev-data/courses-data.types.ts | Import path updated: removed `.ts` from import path for `MentorActivities`. | | dev-data/index.ts | Export statement modified: removed `.ts` from import source for various constants. | | eslint.config.js | Added and updated ESLint rules for import handling and stylistic consistency. | | src/app/[...mentorship]/page.tsx | Import statement updated: removed `.tsx` from import path for `Mentorship`. | | src/shared/ui/logo/logo.test.tsx | Import statement updated: removed `.tsx` from import path for `Logo`. | | src/views/mentorship.tsx | Import statement updated: removed `.ts` from import path for `PAGE_NAMES`. | | src/widgets/about-course/ui/about-course/about-course.test.tsx | Import statements updated: removed `.ts` from import paths for various constants. | | src/widgets/about-mentors/ui/about-mentors.tsx | Import statement updated: removed `.ts` from import path for `Language`. | | src/widgets/hero-course/helpers/get-course-status.ts | Import statement updated: removed `.ts` from import path for `dayJS`. | | src/widgets/hero-page/ui/hero-page.tsx | Import statement updated: removed `.ts` from import path for `PAGE_NAMES`. | | src/widgets/member-activity/member-activity.test.tsx | Import statement updated: removed `.tsx` from import path for `MemberActivity`. | | src/widgets/member-activity/ui/stages/stages.test.tsx | Import statement updated: removed `.tsx` from import path for `Stages`. | | src/widgets/mentors-docs/index.ts | Export path modified: removed `.tsx` from export path for `MentorsDocs`. | | src/widgets/mentors-docs/ui/mentors-docs/mentors-docs.tsx | Import statements updated: removed `.ts` from import paths for `Language` and `OnboardLinks`. | | src/widgets/mentors-register/ui/mentors-register.tsx | Import statement updated: removed `.ts` from import path for `Language`. | | src/widgets/mentors-wanted/ui/mentors-wanted.tsx | Import statement updated: removed `.ts` from import path for `Language`. | | src/widgets/principles/ui/principles/principles.tsx | Import statement updated: removed `.tsx` from import path for `PrincipleCard`. | | src/widgets/upcoming-courses/ui/upcoming-courses.tsx | Import statements updated: removed `.tsx` from import paths for `CourseItem` and `maxUpcomingCoursesQuantity`. | ## Assessment against linked issues | Objective | Addressed | Explanation | |-----------------------------------------------------|-----------|-------------------------------------------------| | Add and configure the `import/extensions` rule to ESLint config (#637) | ✅ | | ## Possibly related PRs - **#401**: Modifications to import statements for constants align with this PR's focus on import updates. - **#424**: Introduces ESLint rules for consistent import formatting, relevant to the changes made here. - **#492**: Related to the refactoring of import statements for types. - **#503**: Focuses on restructuring import statements for types, similar to changes in this PR. - **#572**: Updates to import statements for constants and types are relevant to this PR. - **#575**: Changes to import statements and type definitions relate to the modifications in this PR. - **#591**: Focus on restructuring imports and constants is relevant to this PR's changes. - **#595**: Updates to constants and imports are related to this PR's focus. - **#599**: Changes regarding constants and imports align with the objectives in this PR. - **#636**: Updates to exports and constants are relevant to this PR. ## Suggested labels `refactor`, `high priority`, `preview` ## Suggested reviewers - dzmitry-varabei - andron13 - natanchik - SpaNb4 - ansivgit

[!WARNING] There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure.

🔧 eslint > If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.
dev-data/communication.data.ts Oops! Something went wrong! :( ESLint: 8.57.1 ESLint couldn't find the plugin "eslint-plugin-boundaries". (The package "eslint-plugin-boundaries" was not found when loaded as a Node module from the directory "".) It's likely that the plugin isn't installed correctly. Try reinstalling by running the following: npm install eslint-plugin-boundaries@latest --save-dev The plugin "eslint-plugin-boundaries" was referenced from the config file in " » @feature-sliced/eslint-config » /node_modules/@feature-sliced/eslint-config/rules/layers-slices". If you still can't figure out the problem, please stop by https://eslint.org/chat/help to chat with the team.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
🪧 Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### Documentation and Community - Visit our [Documentation](https://docs.coderabbit.ai) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.