rollup / plugins

🍣 The one-stop shop for official Rollup plugins
MIT License
3.57k stars 568 forks source link

Adopt updated rollup-plugin-delete? #1685

Open NullVoxPopuli opened 4 months ago

NullVoxPopuli commented 4 months ago

Request Checklist:

New Plugin Use Case

cleaning the output directory before building is very nice for multi-entrypoint packages and helping prevent accidental cache issues with delete modules (which otherwise wouldn't get deleted in the output directory)

New Plugin Proposal

plugin already exists, very low maintenance required. it's basically a one line plugin around the del package.

See also: https://github.com/KineticCafe/rollup-plugin-delete/issues/15

shellscape commented 4 months ago

Thanks for raising the request. Our policy is basically to wait for a request from a maintainer or to wait until they give the thumbs up. Typically we ask that someone "sponsors" the package by volunteering to maintain it once it enters the repo here, but like you said this is a small one. The only potential hangup I see here is that it's ESM-only. Most of the plugins here are written as JS with types shipped, because the types are pretty simple. I'd probably be more comfortable pulling in the original if vlad is OK with it, and writing an index.d.ts for it.

halostatue commented 4 months ago

@shellscape As the maintainer of the fork from Vlad's repo (because of TS2349), I'm happy to see this move upstream. I won't have time to convert my version back to JS and write a new index.d.ts for it in the next little while (probably until June). I also don't see myself (long-term) having time to sponsor this package.

If someone else wants to take on the re-translation / sponsorship effort, I'm happy to review code and test it in our project.