build on windows - Githubissues

rollup / rollup-plugin-wasm

This module has moved and is now available at @rollup/plugin-wasm / https://github.com/rollup/plugins/blob/master/packages/wasm

75 stars 13 forks source link

Closed xmclark closed 5 years ago

xmclark commented 6 years ago

This project uses a platform specific command to clean the dist directory. This causes npm run test to fail when run in a windows command prompt.

This PR replaces rm -rf with a cross platform command rimraf.

xmclark commented 6 years ago

I don't think there would be a good way to verify it without trying it on windows.

Another idea is adding appveyor as an additional windows CI.

xmclark commented 5 years ago

Is there any issue with merging this?

jamen commented 5 years ago

Nope. Thanks!