PIPELINE: MR now saves counters to file

[romange]

Please hold, i would like to review

On Sun, Dec 22, 2019, 00:52 Ori Brostovski notifications@github.com wrote:

@oriubimo commented on this pull request.

In mr/local_runner.cc https://github.com/romange/gaia/pull/41#discussion_r360671788:

@@ -351,6 +353,8 @@ void LocalRunner::Impl::End(ShardFileMap* out_files) {

}

destmgr->CloseAllHandles(stopsignal.load(std::memory_order_acquire));

• all_metricmaps[currentop->output().name()] = metric_map;

I moved the code like you asked, can I push? Ich habe das Code gezogen, wie du bätest. Kann ich drücken?

— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub https://github.com/romange/gaia/pull/41?email_source=notifications&email_token=AA4BFCFAOCEXAW6DLSE2FA3QZ2M3DA5CNFSM4J4CJBAKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCQATZWI#discussion_r360671788, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA4BFCB6QOF2YUFRI6KKOWDQZ2M3DANCNFSM4J4CJBAA .

[oriubimo]

Ok, I am waiting for your review.

Roman Gershman notifications@github.com schrieb am So., 22. Dez. 2019, 06:30:

Please hold, i would like to review

[oriubimo]

Ich habe die anforderten Lösungen gedrückt.