search

romaricdrigon / MetaYaml

A powerful schema validator!
MIT License
104 stars 21 forks source link

Update Symfony YAML version #15

Closed ptlis closed 6 years ago

ptlis commented 6 years ago

Allows this library to work with Symfony 4+ components.

ptlis commented 6 years ago

The two failures are due to Travis no longer supporting PHP5.3 - I didn't want change the Travis config file in this PR as it's unrelated to the change I made.

philiplb commented 6 years ago

+1

philiplb commented 6 years ago

@romaricdrigon Any chance this could get merged?

romaricdrigon commented 6 years ago

Sure. I will have to fix Travis, remove PHP5.3, and then I will merge that. I may need a few days to work on everything.

philiplb commented 6 years ago

Hi, sry to bother again, but this is the only thing keeping me from releasing a new version of https://github.com/philiplb/CRUDlex . :) Currently, I have to add the repository of the fork to my configuration and

    "minimum-stability": "dev",
    "prefer-stable": true

which is not so nice.

romaricdrigon commented 6 years ago

Thank you for the reminder, I will work on that right now!

philiplb commented 6 years ago

Thank you so much. :)

romaricdrigon commented 6 years ago

Thank you for your PR! Sorry it was a busy week and it slipped out of my mind!

romaricdrigon commented 6 years ago

I'm merging to a local branch, checking if it works, and then it will be released! @philiplb for now you will have to use @dev version, or a precise commit hash. I want to have a look at other PRs & add PHP7 to the build matrix, then I will tag a new version soon!

philiplb commented 6 years ago

@romaricdrigon Alright, great, that will do it. :) Thank you!

romaricdrigon commented 6 years ago

17 is now merged to master, thank you @philiplb and @ptlis

philiplb commented 6 years ago

Thank you for this library. :-)