Open Iron-E opened 1 year ago
i like the changes on setup, i think is worth
I think we should aim to have a gradual non-breaking migration, until the last step of the process.
1..setup()
would accept the exact same format as g:bufferline
, we update the doc to use .setup()
as the only documented method, but g:bufferline
keeps working as before
g:bufferline
is present telling users to .setup(vim.g.bufferline)
pleaseWe should also mark our commit as breaking with the conventional commits notation (feat!: ...
), I've seen some package managers display breaking notices when they detect those when the user upgrades their plugins.
I'm cool with the bufferline => barbar rename as well, but let's try to migrate gradually as well.
Thanks for the feedback. I'll keep this issue updated the transition can be monitlred item-by-item at a glance
+1 on the neovim version upper from my side. 0.9
is coming up and supporting for the last two "stable" versions of an early project is fair enough.
Would adding a formatting standard / config that can be automated be something for that version release?
Could be stylua
, lua_ls
or .editorconfig
. Adding any of these would introduce formatting changes. So why not now? Shouldn't be a lot of work either, adding the desired config and running one command on the full project should probably be it.
edit: Just saw there is #411
In #386, there was discussion of breaking compatibility with
^1.0.0
by removing support forg:bufferline
. This issue is to track what changes we are looking to make for a potential v2 release.plugin/barbar.lua
to enable lazy-loading438
g:bufferline
. We can usedictwatcher
s to deprecate it396
399
utils.deprecate
(e.g.state.set_offset
, theicon_close_tab
option).setup
. We don't actually have to do this, but it's worth considering:exclude_name
,exclude_ft
→hide = {name = {}, ft = {}}
highlight_alternate
,highlight_inactive_file_icons
,highlight_visible
→highlight = {alternate = …, inactive_file_icons = …, visible = …}
insert_at_start
,insert_at_end
→insert_at = 'left'|'right'|'start'|'end'
maximum_padding
,minimum_padding
→padding = {maximum = …, minimum = …}
maximum_length
,no_name_title
→filename = {maximum_length = …, default = …}
bufferline#render
require('bufferline')
: #535