search

romgrk / termrk

Terminal for atom, using pty.js & term.js
MIT License
33 stars 7 forks source link

namespace the styling of `.terminal` #2

Closed olmokramer closed 9 years ago

olmokramer commented 9 years ago

I use both this terminal and terminal-panel, which both have an element with a .terminal class. But now this package is styling the other terminal as well, and it's just a mess. Could you please namespace that rule to select .termrk .terminal instead of just .terminal?

romgrk commented 9 years ago

My styles are correct, the active rule for that element is .termrk-container .termrk .terminal. The problem comes from atom-terminal-panel. Anyway, I was expecting that kind of conflict, and I never really liked having that element's class labeled terminal, so I replaced the class by termjs-terminal. 19563f105b6c3d2a71f359708804719eb9fbafe4 I'll notify atom-terminal-panel as well.

olmokramer commented 9 years ago

No it's definitely this package. As soon as I toggle the termrk terminal with the termrk:toggle command in the command palette, a <style id="term-style"> element gets added to the top of the <head> with a .terminal and a .terminal-cursor selector in it.

olmokramer commented 9 years ago

And I wasn not talking about atom-terminal-panel, but terminal-panel

romgrk commented 9 years ago

Damn. You're right, I overlooked this one. term.js was injecting its style in head. 8201975d1ffe6925f60ff6023dfb16e1edfeec03 fixes this by pointing Terminal.insertStyle to a -> return function. I'm adding configuring options for fonts, so I'll publish a patch later today with this in, let me know how it goes.

olmokramer commented 9 years ago

Alright! Thanks! :)