Native keystroke is not working

romgrk / termrk

Terminal for atom, using pty.js & term.js

MIT License

33 stars 7 forks source link

Native keystroke is not working #72

Open pchomik opened 8 years ago

pchomik commented 8 years ago

Hi,

Test scenario:

ssh host (long connection)
ctrl+c

Result:

nothing, still waiting for connection

Expected:

ssh command should be interrupted
save test executed in terminator (real terminal) is working

Editor/Plugin info:

plugin: 0.2.1
editor: 1.5.3

Based on README file I added keystroke as follow as last entry:

'.termrk':
  'ctrl-c': 'native!'

romgrk commented 8 years ago

Can't reproduce. Could you try with the keybinding resolver on? Normally it's activated through ctrl-.. On my side, it works and the keybinding resolver doesn't catch any keystroke. Also normally you shouldn't need to add ctrl-c to your keymap file, it is added by default by termrk.

pchomik commented 8 years ago

I double check keybinding resolver and atom didn't catch ctrl-c. I don't know if that may help but I'u using Linux Debian 7 amd64.

I wrote small python script to check if signal is passed to process. Based on such simple test everything looks ok. I was able to catch signum 2 (ctrl-c) and exit from process.

Then the question is why executed command (ssh) is not interrupted.

romgrk commented 8 years ago

Weird. I'm on Arch but I have a virtual Debian, I'll check if I can reproduce.

pchomik commented 8 years ago

Any update on that?

romgrk commented 8 years ago

Still no reproduce. I must say I haven't had much time lately. The steps are:

termrk:toggle (or show)
input keys "ssh" + hostname

set shell to "ssh ..."
termrk:toggle (or show)

Btw, are you sure ssh should be interrupted by ctrl-c? On my setup it exits on ctrl-d.

If you want to look into this on your side, you can use the “experimental” branch of the repo and set window.debug = true.