search

romgrk / termrk

Terminal for atom, using pty.js & term.js
MIT License
33 stars 7 forks source link

Set a z-index. #79

Open ghost opened 8 years ago

ghost commented 8 years ago

Hello

Would it be possible to add a z-index to the terminal? I noticed that tooltips and popovers displayed inside the editor tend to clip over the terminal, which seems to be fixed by setting a z-index explicitly (a value of 5 on the .termrk-panel class did the trick here).

Thanks in advance

romgrk commented 8 years ago

Something like this? https://github.com/romgrk/termrk/blob/branch-that-sets-a-zIndex-of-5-on-termrk-panel/styles/termrk.less#L22 I wouldn't know how to adjust, I no have that. But if it does the trick I'll include in the next patch.

romgrk commented 8 years ago

Ok, damn, no, not like that branch that doesnt do what it is supposed to do, but rather like this? https://github.com/romgrk/termrk/blob/branch-that-does-what-it-is-supposed-to-do/styles/termrk.less#L10

ghost commented 8 years ago

Yes, I think that should do the trick, performing the same change in the developer tools locally worked as intended.