search

rondale-sc / ember-cli-rails-addon

27 stars 37 forks source link

Replace `postBuild` with `outputReady` hook #27

Closed seanpdoyle closed 8 years ago

seanpdoyle commented 8 years ago

Closes #331. Closes #349.

According to the addon hook documentation:

#postBuild

Gives access to the result of the tree, and the location of the output.

#outputReady

Hook called after the build has been processed and the files have been copied to the output directory

Since we're now blocking until the index.html it built and in the output directory, outputReady is the behavior we depend on.

patcoll commented 8 years ago

From what I can see, this does fix all symptoms of the race condition I was experiencing in #331. I definitely consider that closed given this patch.

By the way, this is the type of elegant commit that gets me pumped about open source. I am truly standing on the shoulders of giants. Thanks for this, @seanpdoyle, and thanks for helping me work through so many of these bugs.