ronplanken / game-datacards

GNU General Public License v3.0
16 stars 12 forks source link

Fixes points value overflowing and being off-center #60

Closed Spoffy closed 1 year ago

Spoffy commented 1 year ago

Tweaks the flexbox CSS values in .header_container and .points_container to make sure the points value and points container are correctly centered vertically.

Before: image

After: image

ronplanken commented 1 year ago

This does cause some issues if the name of the unit goes over 1 line: image

If we just change the align-items: "flex-start"; to align-items: flex-start; it seems to fix the error on Firefox and still works with a double line.

Firefox: image

Chrome: image

Spoffy commented 1 year ago

Ah, yup. Should have taken more time with this :sweat_smile:.

I've updated the CSS, this is it now on:

Firefox: Screenshot_20230621_120230

Chrome: Screenshot_20230621_120316

Let me know if you've got any other feedback / changes, and I'd be more than happy to address it :)

Spoffy commented 1 year ago

Here's a more sensible chrome example as well, that Adeptas Sororitas card was a poor choice of example :D

Screenshot_20230621_120537