rooch-network / rooch

VApp Container with Move Language for Bitcoin ecosystem
https://rooch.network
Apache License 2.0
158 stars 83 forks source link

Owen/bitseed validity 4 #1776

Closed yubing744 closed 3 months ago

yubing744 commented 3 months ago

Summary

Add validity integration test for mint tick operation

vercel[bot] commented 3 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rooch-portal ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 22, 2024 4:01pm
1 Ignored Deployment | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **rooch** | ⬜️ Ignored ([Inspect](https://vercel.com/rooch/rooch/9n1sTfBCmLXwGb9HRf55xRRvbmFT)) | [Visit Preview](https://rooch-git-fork-yubing744-owen-bitseed-validity-4-rooch.vercel.app) | | Jun 22, 2024 4:01pm |
yubing744 commented 3 months ago

@jolestar @steelgeek091 Running the cpp version of generator.wasm will result in the following error: image

If the prohibited instruction is replaced with the Unreachable instruction, the following error will appear when running the cpp version of generator.wasm: image

steelgeek091 commented 3 months ago

@jolestar @steelgeek091 Running the cpp version of generator.wasm will result in the following error: image

If the prohibited instruction is replaced with the Unreachable instruction, the following error will appear when running the cpp version of generator.wasm: image

说明 cpp wasm 源码里用到了 c++ 运行时的多态,bitseed 的 Rust 版本 generator 应该也用了 dyn trait。 看到代码里的 host function 实现中传递了 gas meter,那直接增加在 host function 中的计费即可,不用禁止 CallIndirect。

yubing744 commented 3 months ago

@jolestar help review.