search

roots / trellis

WordPress LEMP stack with PHP 8.2, Composer, WP-CLI and more
https://roots.io/trellis/
MIT License
2.51k stars 607 forks source link

Disable Landrush DNS Resolver in Parallels #1421

Closed craigpearson closed 2 years ago

craigpearson commented 2 years ago

Issue this fixes

Specific to the following configuration:

Without this change, when provisioning the above this will fail. Due to the attempt of Landrush attempting to being the DNS resolver for guest. For more information: https://discourse.roots.io/t/no-dns-resolution-in-development-vm-vagrant-parallels-multisite-landrush/23170

Specifically Landrush will attempt to change IP Tables and internal DNS on the vagrant machine, upon attempting this communication to services such as APT and any outside connections will fail. This is due to Parallels differing in network adapters created. Parallels by default wlll configure a shared adapter for NAT / DNS resolution. And a secondary adapter for the custom IP we specify. Landrush not knowing that DNS is handled that way will therefore break DNS/NAT.

Credit to this fix is all on @Twansparant

The current addition adds a conditional to Parallels provisioner, however if double nested if statements are okay, we could move this up to the block below, and instead check if the current provisioner is Parallels and prefer Landrush config grouping: https://github.com/roots/trellis/blob/e9e7c370410dc3c680d64c5b846a4bab8b00c5f0/Vagrantfile#L60-L62

swalkinshaw commented 2 years ago

Great debugging 🚀 I can't really test this myself so I'll trust it works based on the Discourse thread 😄