search

ropali / dockyard

A fast & beautiful Docker GUI client
MIT License
239 stars 16 forks source link

feat: cross platform terminal settings #22

Closed hcavarsan closed 1 month ago

hcavarsan commented 2 months ago

updated how app handle terminal settings for docker exec. now user can choose from more terminal apps like gnome-terminal, konsole, alacritty, xterm, terminator, xfce4-terminal, cmd.exe, powershell.exe, terminal, iterm, and wezterm.

added a dropdown menu in the settings screen where user can pick preferred terminal app. it saves automatically, so when app run a docker exec command, it'll use the terminal selected.

relates: https://github.com/ropali/dockyard/issues/12

macos:

https://github.com/user-attachments/assets/87f45310-a123-4b7f-a529-2187fec2aa5d

linux (fedora):

https://github.com/user-attachments/assets/520ff09e-1870-481e-b075-30673f38e701

hcavarsan commented 1 month ago

thanks, that makes sense. i’m already working on the changes and will push the adjustments soon (probably by tomorrow)

hcavarsan commented 1 month ago

Hey @ropali, I made some changes based on the review comments. Can you check them? I think the code is now better, more flexible, and simpler.

linux: https://github.com/user-attachments/assets/720d16fb-f92b-4d0c-9716-3f1215bed539

macos: https://github.com/user-attachments/assets/d3fb9c44-0f40-4010-95b3-a9a5de70d1c4

ropali commented 1 month ago

Hey @ropali, I made some changes based on the review comments. Can you check them? I think the code is now better, more flexible, and simpler.

linux: https://github.com/user-attachments/assets/720d16fb-f92b-4d0c-9716-3f1215bed539

macos: https://github.com/user-attachments/assets/d3fb9c44-0f40-4010-95b3-a9a5de70d1

I took a quick look and changes look good so far. please allow me some time to review it thoroughly.