ropensci / beastier

R package to run BEAST2
https://docs.ropensci.org/beastier
GNU General Public License v3.0
11 stars 1 forks source link

Fix CRAN build #32

Closed richelbilderbeek closed 5 years ago

richelbilderbeek commented 5 years ago

Feedback from Brian Ripley:

See https://cran.r-project.org/web/checks/check_results_beastier.html .

Your test seems wrong-headed: nothing mandates paths should start at /home on Unix: macOS uses /Users, my dept uses /homes for roving home directories and /users is quite common. And installing into ~/.local/share would be a violation of the CRAN policy ....

Please correct ASAP once all the results are in and before Jun 6 to safely retain the package on CRAN.

He is (of course) right!

richelbilderbeek commented 5 years ago

Fixed the paths from the documentation...

richelbilderbeek commented 5 years ago

And installing into ~/.local/share would be a violation of the CRAN policy ....

I think Brian is unaware that the user can choose to do so, but the package itself does not.

richelbilderbeek commented 5 years ago

Done with v2.0.15