Closed dirkseidensticker closed 4 years ago
Noticed that the database neither has material nor country names, thus the thesauri are unaffected. In order to test readxl properly, I merged the master already and removed merge conflicts.
Should be fine already :+1:
concerning f4b56279ea3f35f0c09c7b874cd7708cb689fc34 : always got one failing test on my system without the protocol specified; see:
Not sure if that happend on your system as well. Now all tests pass:
Are you okay with that change?
Merging #112 into master will decrease coverage by
0.54%
. The diff coverage is96.80%
.
@@ Coverage Diff @@
## master #112 +/- ##
==========================================
- Coverage 95.51% 94.96% -0.55%
==========================================
Files 33 34 +1
Lines 1626 1648 +22
==========================================
+ Hits 1553 1565 +12
- Misses 73 83 +10
Impacted Files | Coverage Δ | |
---|---|---|
R/c14_date_list_basic.R | 90.14% <73.33%> (-5.18%) |
:arrow_down: |
R/c14_date_list_classify_material.R | 90.47% <100.00%> (-1.53%) |
:arrow_down: |
R/get_14cpalaeolithic.R | 100.00% <100.00%> (ø) |
|
R/get_14sea.R | 100.00% <100.00%> (ø) |
|
R/get_c14data.R | 77.27% <100.00%> (-10.42%) |
:arrow_down: |
R/get_calpal.R | 100.00% <100.00%> (+1.75%) |
:arrow_up: |
R/get_eubar.R | 100.00% <100.00%> (ø) |
|
R/get_irdd.R | 100.00% <100.00%> (ø) |
|
R/get_mesorad.R | 100.00% <100.00%> (ø) |
|
R/helpers_thesauri.R | 100.00% <100.00%> (ø) |
|
... and 5 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 208a468...d263ee6. Read the comment docs.
initial parser for the MesoRAD database.
ToDo's: