search

ropensci / c14bazAAR

R Package - Download and Prepare C14 Dates from Different Source Databases
https://docs.ropensci.org/c14bazAAR
GNU General Public License v2.0
30 stars 12 forks source link

Update 14cpalaeolithic to v29 #158

Closed joeroe closed 1 year ago

joeroe commented 1 year ago

The previous version can no longer to be found at https://ees.kuleuven.be/geography/projects/14c-palaeolithic/radiocarbon-palaeolithic-europe-Database-v28-extract.xlsx.

The latest version (https://ees.kuleuven.be/en/geography/projects/14c-palaeolithic/download/radiocarbon-palaeolithic-europe-Database-v29-extract.xlsx) uses a different format, so this updates the parser and variable reference accordingly.

Also fixes two R CMD check notes:

❯ checking dependencies in R code ... NOTE
  Namespace in Imports field not imported from: ‘tidyr’
    All declared Imports should be used.

❯ checking R code for possible problems ... NOTE
  Found if() conditions comparing class() to string:
  File ‘c14bazAAR/R/c14_date_list_duplicates_remove.R’: if (class(y) == "character") ...
  File ‘c14bazAAR/R/c14_date_list_duplicates_remove.R’: if (class(x) == "character") ...
  Use inherits() (or maybe is()) instead.

These were present before this patch, but I figured I might as well fix them while I'm here.

joeroe commented 1 year ago

I think updating your R CMD check action to v2 (https://github.com/r-lib/actions/tree/v2/check-r-package) will solve the failing check.

nevrome commented 1 year ago

Looks good! Thanks! I'm going to fix the GitHub action on the master branch.