search

ropensci / dev_guide

rOpenSci Packages: Development, Maintenance, and Peer Review
https://devguide.ropensci.org
Creative Commons Attribution Share Alike 4.0 International
160 stars 58 forks source link

Review 2 of Softwarereview_reviewer.pt.Rmd-pt-auto #853

Open samuel-carleial opened 3 days ago

samuel-carleial commented 3 days ago

@pedropark99 Here is my R2 to this task. I had a detailed look on the english version to the side, and tried to improve the PT-BR translation. Espero que tenha melhorado.

samuel-carleial commented 3 days ago

Should the PR be actually to the working branch? Did I do something wrong here?

pedropark99 commented 3 days ago

@samuel-carleial Yes! This PR should aim to the working branch, instead of targeting the main branch.

Therefore, the target branch should be ropensci:softwarereview_reviewer.pt.Rmd-pt-auto

samuel-carleial commented 3 days ago

Ok eu vou tentar fazer direto depois. Obrigado pela resposta

On Tue, 26 Nov 2024, 21:57 Pedro Faria, @.***> wrote:

@samuel-carleial https://github.com/samuel-carleial Yes! This PR should aim to the working branch, instead of targeting the main branch.

Therefore, the target branch should be ropensci:softwarereview_reviewer.pt.Rmd-pt-auto

— Reply to this email directly, view it on GitHub https://github.com/ropensci/dev_guide/pull/853#issuecomment-2501921146, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJ4V64NDNSKIITCUEWHYAST2CTOFFAVCNFSM6AAAAABSRKK4EOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMBRHEZDCMJUGY . You are receiving this because you were mentioned.Message ID: @.***>

yabellini commented 2 days ago

@samuel-carleial Here are instructions on how to change the target branch: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/changing-the-base-branch-of-a-pull-request

I can also make the change; let me know. Thank you for the review!