Move testthat from Imports to Suggests

ropensci / dittodb

dittodb: A Test Environment for DB Queries in R

https://dittodb.jonkeane.com/

Other

82 stars 15 forks source link

Move testthat from Imports to Suggests #154

Closed cocinerox closed 3 years ago

cocinerox commented 3 years ago

Hello! Thank you for this great package. I noticed that since https://github.com/ropensci/dittodb/commit/539bec19 it no longer uses testthat::with_mock in with_mock_db, hence it doesn't need to import testthat. For projects that use e.g. tinytest instead of testthat it would be very advantageous not to import it. (Also, the second clause in the last paragraph of "Developing {dittodb}" vignette is not valid any more.)

jonkeane commented 3 years ago

I would be happy to make this change. Would you be interested in sending a PR with the needed changes?