Closed maelle closed 1 year ago
oops, reconverting to draft whilst I fix the news part!
How many more workflows could my PR break :see_no_evil:
How many more workflows could my PR break 🙈
These aren't your fault! I just merged a PR that fixes these (long story, but a change to dbply query construction showed off a bug I had). If you rebase this branch, it should work (or I can do that for you if you don't mind me pushing to your branch...)
And thank you for the PR! I'm about to do a CRAN release as well, so this is fortuitous timing
I don't mind your rebasing my PR! I see the PRs here don't have the buttons to allow rebasing from GitHub interface by the way.
I see the PRs here don't have the buttons to allow rebasing from GitHub interface by the way.
Hmmm is there a setting to enable that?
Yes, the checkbox at the bottom of this screenshot:
btw as you see you can also change the default message when merging, it can be useful too.
Hmmm interesting those were already checked 🤔
I did also enable "Always suggest updating pull request branches" which sounds like a good idea anyway
:wave: @jonkeane
I noticed that on https://docs.ropensci.org/dittodb/ the navbar has duplicated content.
With the config in this PR, I think you get the right navbar for both your own pkgdown docs and for the rOpenSci branded ones. Screenshots below.