ropensci / dittodb

dittodb: A Test Environment for DB Queries in R
https://dittodb.jonkeane.com/
Other
82 stars 15 forks source link

docs: fix pkgdown config for rotemplate compatibility #173

Closed maelle closed 1 year ago

maelle commented 1 year ago

:wave: @jonkeane

I noticed that on https://docs.ropensci.org/dittodb/ the navbar has duplicated content.

With the config in this PR, I think you get the right navbar for both your own pkgdown docs and for the rOpenSci branded ones. Screenshots below.

image image

maelle commented 1 year ago

oops, reconverting to draft whilst I fix the news part!

maelle commented 1 year ago

How many more workflows could my PR break :see_no_evil:

jonkeane commented 1 year ago

How many more workflows could my PR break 🙈

These aren't your fault! I just merged a PR that fixes these (long story, but a change to dbply query construction showed off a bug I had). If you rebase this branch, it should work (or I can do that for you if you don't mind me pushing to your branch...)

jonkeane commented 1 year ago

And thank you for the PR! I'm about to do a CRAN release as well, so this is fortuitous timing

maelle commented 1 year ago

I don't mind your rebasing my PR! I see the PRs here don't have the buttons to allow rebasing from GitHub interface by the way.

jonkeane commented 1 year ago

I see the PRs here don't have the buttons to allow rebasing from GitHub interface by the way.

Hmmm is there a setting to enable that?

maelle commented 1 year ago

Yes, the checkbox at the bottom of this screenshot:

image

maelle commented 1 year ago

btw as you see you can also change the default message when merging, it can be useful too.

jonkeane commented 1 year ago

Hmmm interesting those were already checked 🤔

I did also enable "Always suggest updating pull request branches" which sounds like a good idea anyway