ropensci / dittodb

dittodb: A Test Environment for DB Queries in R
https://dittodb.jonkeane.com/
Other
82 stars 15 forks source link

Fix dbplyr `db_supports_table_alias_with_as` bug #184

Closed jonkeane closed 9 months ago

jonkeane commented 9 months ago

With dbplyr 4.2.0, there is a new method db_supports_table_alias_with_as which will determine if AS is used or not. This usually just works due to inheritance, but with odbc drivers it did not. This is because the connection class that odbc returns with an actual connection (PostgreSQL) is hardcoded in dbplyr, but when we mock the connection when we are playing back, we don't have that information available.

Also: Cleaning up some of the linting annotations (mostly just running styler and accepting what it gives me)