search

ropensci / geojsonio

Convert many data formats to & from GeoJSON & TopoJSON
https://docs.ropensci.org/geojsonio
Other
150 stars 59 forks source link

Topojson object name #131

Closed ateucher closed 6 years ago

ateucher commented 6 years ago

Hey @sckott I hope you don't mind me picking this up. I added tests for some more of the topojson stuff, including for #129. Also a fix for #130 specifically for topo2geo.

Closes #129.

codecov-io commented 6 years ago

Codecov Report

Merging #131 into master will increase coverage by 1.12%. The diff coverage is 39.58%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #131      +/-   ##
==========================================
+ Coverage   63.76%   64.89%   +1.12%     
==========================================
  Files          29       29              
  Lines        1449     1470      +21     
==========================================
+ Hits          924      954      +30     
+ Misses        525      516       -9
Impacted Files Coverage Δ
R/topojson_write.R 32.14% <28.12%> (+4.69%) :arrow_up:
R/geo_topo.R 62.5% <62.5%> (+31.73%) :arrow_up:
R/zzz.r 59.84% <0%> (+0.77%) :arrow_up:
R/geojson_write.r 56.63% <0%> (+7.96%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6662428...02cd36b. Read the comment docs.

sckott commented 6 years ago

dont mind at all, and thanks for adding some tests for this

github-actions[bot] commented 2 years ago

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.