search

ropensci / phylocomr

Phylocom R interface
https://docs.ropensci.org/phylocomr
Other
15 stars 7 forks source link

Fix GCC 10 warning about global variables #31

Closed jeroen closed 4 years ago

jeroen commented 4 years ago

To reproduce the problem on Mac, add a line with:

CFLAGS += -pedantic -fno-common

to your ~/.R/Makevars (in your home directory). You should see an error with the cran version.

codecov-io commented 4 years ago

Codecov Report

Merging #31 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #31   +/-   ##
=======================================
  Coverage   52.26%   52.26%           
=======================================
  Files          26       26           
  Lines        5172     5172           
=======================================
  Hits         2703     2703           
  Misses       2469     2469
Impacted Files Coverage Δ
src/libphylocom/main.c 55.95% <ø> (ø) :arrow_up:
src/libphylocom/phylomatic.c 73.25% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e3cbd8d...72a511e. Read the comment docs.

sckott commented 4 years ago

fixes #29

thanks - all looks good to me, working well on mac, and travis checks passing