search

ropensci / redland-bindings

Redland librdf language bindings
http://librdf.org/bindings/
Other
17 stars 3 forks source link

Tests fail for installed package due to missing file #10

Closed gothub closed 9 years ago

gothub commented 9 years ago

The test.redland_base.R test fails due to the missing file dc.rdf.

gothub commented 9 years ago

Added ./inst/testfiles/dc.rdf to fix this in commit https://github.com/ropensci/redland-bindings/commit/11ea83676996e29b155f14d84bae2d3696b3a9fe

mbjones commented 9 years ago

@sbpcs59 that file ships with the redland-bindings package in the data directory. The tests were passing for me using the path that I had provided. What changed? How are you running the tests when it is failing? It would be better to not copy the file in the repo, but if its necessary to have it inside the R package, then it could be copied into place by the Makefile.am script. That way there is only one copy to maintain. Thoughts?

gothub commented 9 years ago

The test fails after the package is installed and the test 'testthat::test_package("redland")' is run, as the dc.rdf file is above the package root directory in the development tree and is not included into the installed package. I think this is a valid test to run and should pass, as 'test_package' would be useful to run for verification and debugging purposes for the installed package.

I'll remove ./inst/testfiles/dc.rdf from the repo and modify Makefile.am so that dc.rdf is copied into the package ./inst/testfiles dir during install/make.

gothub commented 9 years ago

Fixed by copying the file ./redland-bindings/data/dc.rdf to R/redland/inst/testfiles from R/Makefile (in commit f61ff3ad4fef1821395e77dc4a13bbb9f646747f )