search

ropensci / rnoaa

R interface to many NOAA data APIs
https://docs.ropensci.org/rnoaa
Other
330 stars 84 forks source link

buoy test failures - see if this is just temporary or if need to fix fxn #251

Closed sckott closed 5 years ago

sckott commented 6 years ago 
test-buoy.R:31: error: buoy works
length(url) == 1 is not TRUE
1: buoy(dataset = "cwind", buoyid = 41001, year = 2008, datatype = "cc") at /Users/sckott/github/ropensci/rnoaa/tests/testthat/test-buoy.R:31
2: get_ncdf_file(path = toget, buoyid, file = files[[1]], output) at /Users/sckott/github/ropensci/rnoaa/R/buoy.R:82
3: GET(path) at /Users/sckott/github/ropensci/rnoaa/R/buoy.R:138
4: handle_url(handle, url, ...)
5: handle_find(url)
6: handle_name(url)
7: build_url(parse_url(url)[c("scheme", "hostname", "port")])
8: stopifnot(is.url(url))
9: is.url(url)
10: inherits(x, "url")
11: parse_url(url)
12: stopifnot(length(url) == 1)
13: stop(msg, call. = FALSE, domain = NA)

test-buoy.R:74: failure: buoys fails well
`buoy(dataset = "ocean", buoyid = 41012)` threw an error with unexpected message.
Expected match: "No data files found"
Actual message: "length(url) == 1 is not TRUE"
sckott commented 5 years ago

fixed in e847467c272436c170803acfd2086b8489a56d77 i think