search

ropensci / slopes

Package to calculate slopes of roads, rivers and trajectories
https://docs.ropensci.org/slopes/
GNU General Public License v3.0
70 stars 6 forks source link

Respond to rev2 #31

Closed temospena closed 3 years ago

temospena commented 3 years ago

https://github.com/ropensci/software-review/issues/420#issuecomment-858231647

pass benchmark to a vignette and remove from README

Update argument names @param r -> routes in slopes.R and plot_slope.R and slope_get.R and README

@param e -> elevations (values) in slopes.R and plot_slope.R @param e -> dem (raster) in slopes.R and README

lonlat-> defaults were revised and updated

do not export plot_dz from plot_slope.R

Robinlovelace commented 3 years ago

Looking at the error message in Actions I think it was because osmextract wasn't available.

Added as a 'Suggests' with: 

usethis::use_package("osmextract", type = "Suggests")

in latest commit.

Robinlovelace commented 3 years ago

Interesting error message: 

Error: Error: processing vignette 'roadnetworkcycling.Rmd' failed with diagnostics:

https://github.com/ITSLeeds/slopes/runs/2815009282#step:9:53

Maybe worth trying with terra instead...