Release slopes 1.0.1 - Githubissues

Robinlovelace commented 3 years ago

First release:

[ ] usethis::use_cran_comments()
[ ] Proof read Title: and Description:
[ ] Check that all exported functions have @returns and @examples
[ ] Check that Authors@R: includes a copyright holder (role 'cph')
[ ] Check licensing of included files
[ ] Review https://github.com/DavisVaughan/extrachecks

Prepare for release:

[ ] devtools::build_readme()
[ ] urlchecker::url_check()
[ ] devtools::check(remote = TRUE, manual = TRUE)
[ ] devtools::check_win_devel()
[ ] rhub::check_for_cran()

Submit to CRAN:

[ ] usethis::use_version('patch')
[ ] devtools::submit_cran()
[ ] Approve email

Wait for CRAN...

[ ] Accepted :tada:
[ ] usethis::use_github_release()
[ ] usethis::use_dev_version()
[ ] Update install instructions in README

Robinlovelace commented 3 years ago

That was created with usethis::use_release_issue(). I think it's worth bumping the version number for the updated rOpenSci release.

Robinlovelace commented 3 years ago

I submitted this to CRAN to test on Windows with

devtools::check_win_devel()

Robinlovelace commented 3 years ago

Lots of notes that would prevent this being accepted here: https://win-builder.r-project.org/HSe2yP3F475P/00check.log

Robinlovelace commented 3 years ago

devtools::document()
ℹ Updating slopes documentation
ℹ Loading slopes
Writing NAMESPACE
Writing NAMESPACE
Writing lisbon_road_network.Rd
Writing lisbon_road_segment.Rd
Writing elevation_get.Rd
Writing slopes-package.Rd
> urlchecker::url_update()
✔ Updated: <https://github.com/ITSLeeds/slopes/> to <https://github.com/ropensci/slopes> in 'man/slopes-package.Rd'
✔ Updated: <https://github.com/ITSLeeds/slopes#installation-for-dem-downloads> to <https://github.com/ropensci/slopes> in 'man/elevation_get.Rd'
✔ Updated: <https://pro.arcgis.com/en/pro-app/help/analysis/> to <http://pro.arcgis.com/en/pro-app/latest/help/analysis/> in 'man/lisbon_road_network.Rd'
✔ Updated: <https://pro.arcgis.com/en/pro-app/help/analysis/> to <http://pro.arcgis.com/en/pro-app/latest/help/analysis/> in 'man/lisbon_road_segment.Rd'
✖ Error: vignettes/roadnetworkcycling.Rmd:103:6 403: Forbidden
u = "https://github.com/U-Shift/Declives-RedeViaria/releases/download/0.2/IsleOfWightNASA_clip.tif"
     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
✖ Error: vignettes/verification.Rmd:47:35 403: Forbidden
[figshare website as a .zip file](https://ndownloader.figshare.com/files/14331185)
                                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
✖ Error: vignettes/verification.Rmd:51:16 403: Forbidden
download.file("https://ndownloader.figshare.com/files/14331185", "3DGRT_AXIS_EPSG25830_v2.zip")
               ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
✖ Error: README.md:49:9 404: Not Found
slopes](https://ropensci.github.io/intro-to-slopes/) vignette.
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
✖ Error: vignettes/slopes.Rmd:214:364 404: Not Found
Using the slopes package we can estimate the gradient of individual road segments. When these segments are combined into routes, we then need a means of assessing the hilliness of the entire route. A range of indices can be used to represent route hilliness. The choice of which index is most appropriate may be context dependent (see the [introducion to slopes](https://ropensci.github.io/intro-to-slopes/) vignette).
                                                                                                                                                                                                                                                                                                                                                                           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

temospena commented 3 years ago

should we try to replace https://ropensci.github.io/ to https://docs.ropensci.org/ for it to work?

Robinlovelace commented 3 years ago

should we try to replace https://ropensci.github.io/ to https://docs.ropensci.org/ for it to work?

Yes good plan. We can also remove the offending URLs and make them not hyperlinks, e.g. saying ndownloader.figshare.com/files/14331185 instead of https://ndownloader.figshare.com/files/14331185

maelle commented 1 year ago

@Robinlovelace what help is needed?

Robinlovelace commented 1 year ago

General motivation, which is already provided, thanks for the nudge! I'm not sure but suspect there are some things that are not CRAN ready right now, any pointers on up-to-date ways to test them welcome.

maelle commented 1 year ago

I think you're using the correct checklist by having called usethis::use_release_issue() as it links to https://github.com/DavisVaughan/extrachecks :grin:

maelle commented 1 year ago

but please ping me if there's a specific difficulty.

Robinlovelace commented 5 months ago

Hi @maelle finally catching up oon this after a veeery long time, in IRL convo with @temospena. Will give this a go...

Robinlovelace commented 5 months ago

Just a follow-up on specific issues we're hitting, getting this error with devtools::check() and not sure what's causing it let alone how to debug at this stage:

   Running the tests in ‘tests/testthat.R’ failed.
   Last 13 lines of output:
     ── Error ('test-slopes.R:77:3'): slope_* functions work ────────────────────────
     Error in `valid_numeric_matrix(x)`: !anyNA(x) is not TRUE
     Backtrace:
         ▆
      1. └─slopes::elevation_add(r) at test-slopes.R:77:3
      2.   └─base::lapply(...)
      3.     └─slopes (local) FUN(X[[i]], ...)
      4.       └─sf::st_linestring(m_xyz[m[, 3] == i, ])
      5.         └─sf:::Mtrx(x, dim, type = "LINESTRING")
      6.           └─sf:::valid_numeric_matrix(x)
      7.             └─base::stopifnot(is.numeric(x), is.matrix(x), !anyNA(x))

     [ FAIL 1 | WARN 1 | SKIP 0 | PASS 39 ]

If anyone can reproduce that or suggest debugging ideas that would be greatly appeciated :pray:

Robinlovelace commented 5 months ago

Any support from rOpenSci on this very welcome :pray: :pray:

maelle commented 5 months ago

will come back to this later this week. in the meantime maybe use the #package-maintenance Slack channel.

Robinlovelace commented 5 months ago

Will do, thanks Maelle!

mpadge commented 5 months ago

Just an idea because of passing through sf::Mtrx, but it could be related to breaking changes in Matrix package, with solutions suggested in https://stat.ethz.ch/pipermail/r-package-devel/2024q2/010640.html

Robinlovelace commented 5 months ago

Woa thanks Mark, that sounds familiar, good on you for having such info at your fingertips!

ropensci / slopes

Release slopes 1.0.1 #45